Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update targetSDK, buildTools, support library and maven plugin #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

madlymad
Copy link

Note that during build a warning appeared.

Warning:The android.dexOptions.incremental property is deprecated and
it has no effect on the build process.

Warning:The `android.dexOptions.incremental` property is deprecated and
it has no effect on the build process.
@virl
Copy link
Contributor

virl commented Dec 24, 2016

@madlymad targetSdkVersion 24 is not currently supported by sources, because it requires support for runtime app permissions.

@madlymad
Copy link
Author

Thanks, Good to know that 👍

@madlymad
Copy link
Author

Do you have any problem on depending on an extra library for the permission handling or this just an issue you just not had time to look so far?

Generally there are a lot of libraries for this handling https://android-arsenal.com/tag/235.

I am asking because I want to test your library and if it helps the connectivity issue that I am trying to solve I'll added to one of my ongoing projects, so this will be one of my problems that either I have to workaround or implement in the library side.

Thanks for your time.

@virl
Copy link
Contributor

virl commented Dec 24, 2016

@madlymad Currently I'm in the process of refactoring of entire Android library, mainly to improve connectivity logic and memory handling. I'm doing this refactoring on private repository, not on GitHub, because I decided to change business model to closed source (but binary version will be available for free anyway).
Support for runtime permissions will be implemented at the end of that refactoring.

Generally I think that this networking library should not depend on any third-party permissions library, because different apps/users have different preferences for such permissions libraries and even can use another in their app already.
Also such dependency can potentially make building of library more fragile.

Due to that this networking library should implement callback/listener api for requesting specific permissions that it needs from the app and hosting app itself should decide what library use to request these permissions. After they are granted/denied, it should notify networking library about it.

@Faolain
Copy link

Faolain commented Oct 25, 2020

@virl any updates on that refactor? It looks like the underdark domain is now offline so I'm curious what happened to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants